Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react] Require initial value for useRef #64920

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

[react] Require initial value for useRef #64920

wants to merge 16 commits into from

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Mar 28, 2023 •
edited

Implements https://twitter.com/dan_abramov/status/1640157848167489541
Stacked on #64896 (Diff against #64896)

useRef now requires an explicit initial value. This is in line with documentation and createContext

-const ref = React.useRef<T>()
+const ref = React.useRef<T>(undefined)
 //     ^? React.RefObject<T | undefined>

Just like for const current: T | null = useRef<T>(null).current we'll have a convenience overload for useRef<T>(undefined) that ensures ref.current will be T | undefined.

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Mar 28, 2023
This was referenced Mar 28, 2023
Draft
Merged
@github-actions github-actions bot mentioned this pull request Dec 5, 2023
Merged
This was referenced Mar 26, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Igorbek Igorbek Awaiting requested review from Igorbek Igorbek will be requested when the pull request is marked ready for review Igorbek is a code owner

@peterblazejewicz peterblazejewicz Awaiting requested review from peterblazejewicz peterblazejewicz will be requested when the pull request is marked ready for review peterblazejewicz is a code owner

@johnnyreilly johnnyreilly Awaiting requested review from johnnyreilly johnnyreilly will be requested when the pull request is marked ready for review johnnyreilly is a code owner

@Jessidhia Jessidhia Awaiting requested review from Jessidhia Jessidhia will be requested when the pull request is marked ready for review Jessidhia is a code owner

Assignees
No one assigned
Labels
None yet
Projects
New Pull Request Status Board
Needs Author Action
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eps1lon @gaearon