Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Do not allow setting user passwords on the commandline #341

Closed
strugee opened this issue Jan 26, 2021 · 1 comment · Fixed by #342
Closed

[Security] Do not allow setting user passwords on the commandline #341

strugee opened this issue Jan 26, 2021 · 1 comment · Fixed by #342

Comments

@strugee
Copy link
Contributor

strugee commented Jan 26, 2021

This is a security vulnerability because under an out-of-the-box Linux configuration, any user can read any process' command line arguments. That means that a local attacker would be able to see the new password as the command was being run.

To prevent this lxdui user update and friends should drop their -p option and instead only accept passwords interactively or via environment variable (environment variables are secure because they do not have the same problem, and they can be used in noninteractive settings just as easily).

@vhajdari
Copy link
Contributor

vhajdari commented Jan 26, 2021 via email

strugee added a commit to strugee/lxdui that referenced this issue Jan 27, 2021
strugee added a commit to strugee/lxdui that referenced this issue Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants