Adds an exclude option to the create_lambda_zip method. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you clean this up a bit? There are a few random print statements, and a hard-coded path that includes your own system's path. It'd be good if the the '.DS_Store', '.git', etc could call use the same exclude system. |
Miserlou
pushed a commit
that referenced
this pull request
Mar 2, 2016
Adds an exclude option to the create_lambda_zip method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's nice to be able to exclude stuff that you don't want uploaded, but which are still in the project root. This enables the
create_lambda_zipmethod to receive an extra parameter which should be a list of patterns to exclude.The patterns support relative, and absolute, and unix like syntax through the fnmatch module.
E.g.
exclude = ['./foo/*', '*.git*', '*.DS_Store', 'tmp/*']will exclude all files in thefooand 'tmp' directories, and all git-related and OS X related stupid files.Still needs to be hooked up to the respective cli's.