MudAutocomplete: ItemDisabledTemplate and ItemSelectedTemplate will now display even if ItemTemplate is not defined.
#8913
Conversation
…emTemplate was null Previously when ItemTemplate was null, ItemDisabledTemplate/ItemSelectedTemplate would not show. Now ItemDisabledTemplate takes priority, then ItemSelectedTemplate, then ItemTemplate, finally just the string if all are null.
Shows how to use the ItemDisabledTemplate to customize a disabled item.
Reworded text a little, and added ItemDisabledTemplate.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8913 +/- ##
==========================================
+ Coverage 89.82% 90.46% +0.63%
==========================================
Files 412 419 +7
Lines 11878 12189 +311
Branches 2364 2380 +16
==========================================
+ Hits 10670 11027 +357
+ Misses 681 629 -52
- Partials 527 533 +6 ☔ View full report in Codecov by Sentry. |
|
Hi. |
|
@danielchalmers probs will conflict with #8914 as same line was modified |
Tests that the ItemDisabledTemplate and ItemSelectedTemplate both can display when ItemTemplate isn't provided (null)
For use with "AutocompleteItemTemplateDisplayTest" Test in AutocompleteTests.cs
|
Test is now added @henon @danielchalmers @ScarletKuro Test passes on my branch and fails on dev. The test component has both the On my branch: On dev: |
|
@digitaldirk what would you write in the migration guide? Just a one-liner please |
|
ItemDisabledTemplate and ItemSelectedTemplate will now display even if ItemTemplate is not defined.
|
Thanks @digitaldirk Added to v7.0.0 Migration Guide #8447 |
Description
Updated the logic for choosing which template (or just the string) for an item. Previously if the ItemTemplate was null, then ItemDisabledTemplate/ItemSelectedTemplate would not display.
Fixes #8912
How Has This Been Tested?
Visually tested via docs and own project.
Type of Changes
Would this be a visually breaking bug? If someone defined just a ItemDisabledTemplate and no others, before this fix their MudAutocomplete would be "normal" and after this fix then the disabled items could look different. This approach also prioritizes the templates in this order: ItemDisabledTemplate -> ItemSelectedTemplate -> ItemTemplate -> item string. An example to think about: if all these templates were defined, and programmatically we selected an item that is marked as Disabled in a MudAutocomplete then how should it show? I believe disabled is the best choice here but would love to hear opinions about this.
Docs demo:
Current behavior:
You can see how the ItemDisabledTemplate does not display when the ItemTemplate is null here: https://try.mudblazor.com/snippet/GkmIuTaLryaVxwKA
Checklist
dev).