Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MudCheckBox, MudRadio, MudSwitch: Fix shouldn't hover when ReadOnly and rename UncheckedColor #8759

Merged
merged 9 commits into from
Apr 21, 2024
Merged

MudCheckBox, MudRadio, MudSwitch: Fix shouldn't hover when ReadOnly and rename UncheckedColor #8759

merged 9 commits into from
Apr 21, 2024

Conversation

henon
Copy link
Collaborator

@henon henon commented Apr 20, 2024

Description

MudCheckBox, MudRadio, MudSwitch: Fix shouldn't hover when ReadOnly and rename UncheckedColor

How Has This Been Tested?

unit | visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added breaking change bug Something does not work as intended/expected PR: needs review labels Apr 20, 2024
@henon henon added API change API that needs approval v7 New major MudBlazor version and removed PR: needs review labels Apr 20, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 20, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.11%. Comparing base (28bc599) to head (415dcf4).
Report is 100 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8759      +/-   ##
==========================================
+ Coverage   89.82%   90.11%   +0.28%     
==========================================
  Files         412      419       +7     
  Lines       11878    12195     +317     
  Branches     2364     2401      +37     
==========================================
+ Hits        10670    10990     +320     
+ Misses        681      662      -19     
- Partials      527      543      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

danielchalmers
danielchalmers reviewed Apr 20, 2024
View reviewed changes
Copy link
Contributor

@danielchalmers danielchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing.

Also there are ways to refactor the CSS (add styles instead of take away) that I might look into after this but it's a pretty fundamental change so possibly not worth it

src/MudBlazor/Components/Radio/MudRadio.razor.cs Outdated Show resolved Hide resolved
@henon
Copy link
Collaborator Author

henon commented Apr 20, 2024

One small thing.

Also there are ways to refactor the CSS (add styles instead of take away) that I might look into after this but it's a pretty fundamental change so possibly not worth it

Yeah, I am not fluent enough in CSS to be able to do that.

@igotinfected igotinfected mentioned this pull request Apr 20, 2024
Merged
7 tasks
@henon henon mentioned this pull request Apr 21, 2024
Open
@henon henon merged commit 7c7c1f9 into MudBlazor:dev Apr 21, 2024
4 checks passed
@henon
Copy link
Collaborator Author

henon commented Apr 21, 2024

UnCheckedColor renaming added to v7.0.0 Migration Guide #8447

@henon henon deleted the boolean-inputs-readonly-fix branch April 21, 2024 19:38
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
@henon @biegehydra
MudCheckBox, MudRadio, MudSwitch: Fix shouldn't hover when ReadOnly a…
ea09f9e 
…nd rename UncheckedColor (MudBlazor#8759)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anu6is Anu6is Anu6is left review comments

@danielchalmers danielchalmers danielchalmers approved these changes

@igotinfected igotinfected igotinfected left review comments

@ScarletKuro ScarletKuro Awaiting requested review from ScarletKuro

Assignees
No one assigned
Labels
API change API that needs approval breaking change bug Something does not work as intended/expected v7 New major MudBlazor version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@henon @Anu6is @danielchalmers @igotinfected @ScarletKuro