Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons: Remove Material.Obsolete, Update formatting #8536

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

danielchalmers
Copy link
Contributor

Description

Follow up on #8421

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@danielchalmers danielchalmers changed the title Icons: Remove Material.Obsolete, Add EOF newlines Icons: Remove Material.Obsolete, Update formatting Mar 30, 2024
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.31%. Comparing base (f1391d8) to head (e0f2519).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8536      +/-   ##
==========================================
- Coverage   89.32%   89.31%   -0.01%     
==========================================
  Files         411      411              
  Lines       11903    11903              
  Branches     2357     2357              
==========================================
- Hits        10632    10631       -1     
  Misses        750      750              
- Partials      521      522       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro ScarletKuro requested a review from henon March 30, 2024 18:49
@ScarletKuro ScarletKuro added API change API that needs approval refactor Refactoring of code. No bug fixes or new features labels Mar 30, 2024
@mikes-gh mikes-gh merged commit 8518947 into MudBlazor:dev Mar 31, 2024
4 checks passed
@mikes-gh
Copy link
Contributor

Thanks @danielchalmers

@ScarletKuro
Copy link
Member

Wanted to add this to the guide #8447 since some icons are permanently removed, but the list would be huge. So just added the link to the PR.

@danielchalmers danielchalmers deleted the icons-more-cleanup branch April 4, 2024 23:48
biegehydra pushed a commit to biegehydra/MudBlazor that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change API that needs approval breaking change refactor Refactoring of code. No bug fixes or new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants