fix: language-change-issue #18270
Open
fix: language-change-issue #18270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
|
26d0716
to
2e1bdb3
Compare
Boegie19
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
@joshuaellis checked the PR fixes the issues only thing what I am not sure about is that is changes the srcLang of the track to be always English. so I am not sure if that could cause a problem.
|
Thanks for your PR! Could you please target the |
joshuaellis
requested changes
Mar 27, 2024
| @@ -15,7 +15,7 @@ const CardAsset = styled(Flex)` | |||
| `; | |||
|
|
|||
| export const AssetPreview = forwardRef(({ mime, url, name, ...props }, ref) => { | |||
| const [lang] = usePersistentState('strapi-admin-language', 'en'); | |||
| const lang = 'en'; | |||
There was a problem hiding this comment.
I actually think we can just get rid of this and the prop srcLang it's not really needed and iirc you need to know the language of the video, which might not be en.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fix #18156
Describe the technical changes you did.
Removed the
usePersistentStateand madelanglocal to AssetPreview component.Why is it needed?
The media editor dialog was changing the
strapi-admin-languagetoenwhich was overriding the locale chosen by the user.How to test it?
Profilepage and saveEdit asset. Hit refresh, it should not change the language back to englishThanks,
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request