Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choices: hide 'X' reset button if no selection is made. #426

Closed
ignaaaam opened this issue May 9, 2024 · 0 comments · Fixed by #435
Closed

Choices: hide 'X' reset button if no selection is made. #426

ignaaaam opened this issue May 9, 2024 · 0 comments · Fixed by #435
Labels
enhancement New feature or request

Comments

@ignaaaam
Copy link

ignaaaam commented May 9, 2024

maryUI version

1.20

daisyUI version

4.10.2

Livewire version

3.4

What browsers are affected?

Firefox, Chrome, Microsoft Edge

What happened?

✅ For sure you can paste screenshots.

❌ Please, don't paste code as screenshot. Paste as formatted markdown code.

PHP

public bool $modal = false;

HTML/Blade

<x-button label="Hi" />

Hello all, maybe this is intended, but on the Choices component, if I dont have any user or users selected the 'X' of reset still appears, shouldn't be that it doesnt appears when there's no user selected and appear once there's one or atleast one (if it's multiple)? Here's the two examples (blurred the users selected because it's name of real people and can't share that due to privacy)

'X' appearing when no users selected
choices maryUI

'X' when users are selected (thats how it should work when atleast one user is selected should appear instead of being present all time even is nothing is selected)

choices mary users selected with blur
@ignaaaam ignaaaam added the bug Something isn't working label May 9, 2024
@robsontenorio robsontenorio added enhancement New feature or request and removed bug Something isn't working labels May 9, 2024
@robsontenorio robsontenorio changed the title Choices component 'X' reset button still appears when no user is selected Choices: hide 'X' reset button if no selection is made. May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants