Ensure two interfaces with the same name do not cause compile errors #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any documentation I should update? Version history or so? |
|
We are starting to evaluate another release. So will go through these PRs soon. thanks for the contribution. |
Fix unit tests on difference in extra spaces in output.
…o fix/bug-1261
|
I just added a fix for the unit tests. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1542 +/- ##
==========================================
- Coverage 87.73% 86.62% -1.11%
==========================================
Files 33 34 +1
Lines 2348 2064 -284
Branches 294 296 +2
==========================================
- Hits 2060 1788 -272
+ Misses 208 199 -9
+ Partials 80 77 -3 ☔ View full report in Codecov by Sentry. |
ChrisPulman
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes bug #1261.
What is the current behavior?
See bug #1261. In short, source generator fails if there are more than two interfaces with the same name.
What is the new behavior?
Any number of interface with the same name is supported by extending the methodology that supported two interfaces with the same name.
What might this PR break?
Nothing that I expect.
Please check if the PR fulfills these requirements
Other information: