-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Windows) Some buttons get localised to system locale #824
Comments
Those might be translated in Qt directly. You didn't post your settings dump (can you please fill out the issue template). Which language do you have selected in QOwnNotes? |
At that moment I didn't post it because it contained some information I would rather not share (remote domains, usernames, calendar lists), but here it is. QOwnNotes is in English. QOwnNotes Debug InformationGeneral InfoCurrent Date: Server InfoserverUrl: Note folderscurrentNoteFolderId: Note folder
|
That's interesting. What happens to those dialogs if you select an other language or use |
Same deal with Automatic language. Some languages do work as expected though, such as German (https://i.imgur.com/kG148v4.png - look at bottom right) and Italian (https://i.imgur.com/yBCckyE.png) while others like English and Spanish (https://i.imgur.com/pLOXvKb.png) seem don't have those buttons translated. Could it be missing strings in translations? |
Thank you for testing. No, it's rather the opposite. Strings are translated (from the base language English) to the system's local language regardless of the language used in QOwnNotes. That seems to be an upstream problem in Qt on Windows. |
Hm, it could also be a deployment problem of |
@zingmars, could you please test https://ci.appveyor.com/api/buildjobs/xq32ka8efy63ymds/artifacts/appveyor%2FQOwnNotes.zip (from https://ci.appveyor.com/project/pbek/qownnotes/build/windows-b3422/artifacts) for above problems. I tested a Qt 5.9.2 deployment. More languages are included in this build now. Can you please especially also test the dialog buttons in the English language. |
Alas - didn't help - https://i.imgur.com/H34JWwy.png https://i.imgur.com/oM5LJij.png |
Thank you for testing. Strange, it seemed to work on my German Win 8.1 test system... |
Do the language that previously worked still work? |
Yes, there's no change in behaviour. |
Do the buttons work in Spanish? There definitely should now be a |
I also got German buttons under Windows 10 in English, but in Spanish the buttons are Spanish for me. |
If I remove |
Yeah, Spanish has proper buttons. Contents of the translations folder -
|
Expected behaviour
All buttons should have the same locale as the rest of the software.
Actual behaviour
See https://i.imgur.com/ZaeANlj.png, https://i.imgur.com/2Uq3bOX.png. As you can see, the Yes/No buttons are localised to "Jā" and "Nē", which is Latvian for Yes/No. Similar issue can be seen in settings - https://i.imgur.com/YhvNgAO.png (Labi/Atcelt - Confirm/Cancel).
Steps to reproduce
Have Windows with non-English Region set I think. My Windows currently has the enGB locale set, QOwnNotes is set to English. My Region is set to Latvia and my main keyboard language is Latvian.
The text was updated successfully, but these errors were encountered: