Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minecraft Bedrock Edition gamedig monitor queries Java edition server instead of Bedrock #4635

Closed
1 task done
Jayspek opened this issue Mar 31, 2024 · 3 comments
Closed
1 task done
Labels
area:monitor Everything related to monitors blocked-upstream upstream (i.e. a dependency we depend on will have to do this work) bug Something isn't working type:enhance-existing feature wants to enhance existing monitor

Comments

@Jayspek
Copy link

Jayspek commented Mar 31, 2024

πŸ“‘ I have found these related issues/pull requests

None

πŸ›‘οΈ Security Policy

Description

When you create a gamedig monitor and select Minecraft: Bedrock Edition, it queries the server using the Minecraft Java Edition protocol. This results in no response when querying a Bedrock server. If you have a Java and Bedrock server at the same address, the monitor will receive a response from the Java Edition server.

I was able to fix this issue by doing the following:
Opening the games.txt file at {server directory}\nodemodules\gamedig

Then editing the line:

- minecraftpe,minecraftbe|Minecraft: Bedrock Edition (2011)|minecraft|port=19132
+ minecraftpe,minecraftbe|Minecraft: Bedrock Edition (2011)|minecraftbedrock|port=19132

This change causes the Bedrock Edition monitor to query Bedrock Edition servers as intended.
I'm not sure if this is the most optimal place to make this change, but it worked for me without causing any other problems (as far as I can tell).

πŸ‘Ÿ Reproduction steps

Create a Minecraft: Bedrock Edition monitor and direct it to an address that is hosting a Bedrock Edition server.

πŸ‘€ Expected behavior

The monitor will query the server using the Bedrock Editon protocol and get a response form the bedrock server.

πŸ˜“ Actual Behavior

The monitor queries the server with the Java edition protocol, either getting no response or receiving a response from a Java server if there is also one of those at the same address.

🐻 Uptime-Kuma Version

1.23.11

πŸ’» Operating System and Arch

Windows 11 23H2

🌐 Browser

Same across all

πŸ–₯️ Deployment Environment

  • Runtime: nodejs 20.11.0
  • Database: IDK? Whatever is built in
  • Filesystem used to store the database on: NTFS
  • number of monitors: 23

πŸ“ Relevant log output

No response

@Jayspek Jayspek added the bug Something isn't working label Mar 31, 2024
@CommanderStorm
Copy link
Collaborator

That is an upstream issue. (we don't modifiy the dependencys we have like gamedig as suggested by you).
I have not identified a specific issue on this in their issue tracker.

Could you (as more of an expert) look thorugh their issues if this is tracked in another one?

These points from their v5.0.0-beta0 changelog might be relevant

  • Removed minecraftping (as it was deprecated and the same thing as minecraft) and minecraftpe (deprecated, which is now the same as mbe (Minecraft Bedrock Edition)).
  • Removed the games.txt file, the games definitions are now stored in-code (exported on games).

The specific issue tracking the upgrade to v5 is #4414, but nobody has yet done the work to migrate to said version.
v2.0 of uptime kuma will bump our minimum supported node version to 18 => said part is not a blocker anymore.
This dependency not having a stable release means that we currently won't spend core-maintainer time on such a migration and instead focus on other stuff like #4500

@CommanderStorm CommanderStorm added help blocked-upstream upstream (i.e. a dependency we depend on will have to do this work) area:monitor Everything related to monitors type:enhance-existing feature wants to enhance existing monitor and removed help labels Mar 31, 2024
@CommanderStorm
Copy link
Collaborator

I am going to close this issue as as a duplicate, because this is likely also covered by #4414 => better tracked there as minecraftpe was remvoed in said beta0 of gamdig v5

@CommanderStorm CommanderStorm closed this as not planned Won't fix, can't repro, duplicate, stale Mar 31, 2024
@Jayspek
Copy link
Author

Jayspek commented Apr 1, 2024

Ok, thanks you for the insight!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors blocked-upstream upstream (i.e. a dependency we depend on will have to do this work) bug Something isn't working type:enhance-existing feature wants to enhance existing monitor
Projects
None yet
Development

No branches or pull requests

2 participants