Remove branch cache

feenkcom · May 20, 2024 · d135d04 · d135d04
1 parent 980d1dd
commit d135d04
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 26 deletions.
diff --git a/src/GToolkit4Git/GtGitRepository.class.st b/src/GToolkit4Git/GtGitRepository.class.st
@@ -10,7 +10,6 @@ Class {
 	#instVars : [
 		'icebergRepository',
 		'announcer',
-		'isSubscribed',
 		'lepiterWorkingCopy',
 		'status',
 		'viewModel'
@@ -1065,8 +1064,7 @@ GtGitRepository >> incomingCommits [
 { #category : #initialization }
 GtGitRepository >> initialize [
 	super initialize.
-	announcer := Announcer new.
-	isSubscribed := false.
+	announcer := Announcer new
 ]
 
 { #category : #'api - testing' }

diff --git a/src/GToolkit4Git/GtGitRepositoryViewModel.class.st b/src/GToolkit4Git/GtGitRepositoryViewModel.class.st
@@ -130,7 +130,6 @@ GtGitRepositoryViewModel >> onRepositoryModelChanged [
 
 { #category : #callbacks }
 GtGitRepositoryViewModel >> onRepositoryModified: anAnnouncement [
-
 	(self hasRepository and: [ 
 		 anAnnouncement repository = self repositoryModel repository ]) 
 		ifTrue: [ 

diff --git a/src/GToolkit4Git/IceGitCliRepository.class.st b/src/GToolkit4Git/IceGitCliRepository.class.st
@@ -8,7 +8,6 @@ Class {
 		'location',
 		'head',
 		'remoteMap',
-		'branchMap',
 		'revListMap',
 		'commitMap'
 	],
@@ -137,7 +136,6 @@ and the original repository''s url is {3}.'
 { #category : #accessing }
 IceGitCliRepository >> clearCaches [
 	head := nil.
-	branchMap := Dictionary new
 ]
 
 { #category : #actions }
@@ -396,7 +394,6 @@ IceGitCliRepository >> initBare: isBareRepository [
 IceGitCliRepository >> initialize [
 	super initialize.
 	remoteMap := Dictionary new.
-	branchMap := Dictionary new.
 	revListMap := Dictionary new.
 	commitMap := Dictionary new
 ]
@@ -461,15 +458,13 @@ IceGitCliRepository >> lookupLocalBranch: branchName [
 
 { #category : #'API - branches' }
 IceGitCliRepository >> lookupLocalBranch: branchName ifAbsent: aBlock [
-	^ branchMap
-		at: branchName
-		ifAbsentPut: [ | lines |
-			lines := self runGitWithArgs: {
-				'branch'.
-				branchName.
-				'--list'.
-				'--format=%(objectname)' }.
-			lines isEmpty ifTrue: [ aBlock value ] ifFalse: [ lines first ] ]
+	| lines |
+	lines := self
+			runGitWithArgs: {'branch'.
+					branchName.
+					'--list'.
+					'--format=%(objectname)'}.
+	^lines isEmpty ifTrue: [ aBlock value ] ifFalse: [ lines first ]
 ]
 
 { #category : #'API - branches' }
@@ -479,16 +474,14 @@ IceGitCliRepository >> lookupRemoteBranch: branchName [
 
 { #category : #'API - branches' }
 IceGitCliRepository >> lookupRemoteBranch: branchName ifAbsent: aBlock [
-	^ branchMap
-		at: branchName
-		ifAbsentPut: [ | lines |
-			lines := self runGitWithArgs: {
-				'branch'.
-				branchName.
-				'--remotes'.
-				'--list'.
-				'--format=%(objectname)' }.
-			lines isEmpty ifTrue: [ aBlock value ] ifFalse: [ lines first ] ]
+	| lines |
+	lines := self
+			runGitWithArgs: {'branch'.
+					branchName.
+					'--remotes'.
+					'--list'.
+					'--format=%(objectname)'}.
+	^ lines isEmpty ifTrue: [ aBlock value ] ifFalse: [ lines first ]
 ]
 
 { #category : #actions }