Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] prebuild does not respect settings in expo.platforms #18386

Open
hirbod opened this issue Jul 27, 2022 · 7 comments
Open

[CLI] prebuild does not respect settings in expo.platforms #18386

hirbod opened this issue Jul 27, 2022 · 7 comments
Assignees
Labels
CLI Versioned Expo CLI -- `npx expo start` Issue accepted

Comments

@hirbod
Copy link
Contributor

hirbod commented Jul 27, 2022

Summary

Running expo prebuild will always generate ios and android directories, even though I've specified expo.platforms to be ["ios"].

We could use expo prebuild -p ios but I feel like the platforms array in our settings should be respected out of the box. If nothing or something invalid is set, it could still generate both.

What platform(s) does this occur on?

Android, iOS, Web

SDK Version

45

Environment

  expo-env-info 1.0.5 environment info:
    System:
      OS: macOS 12.5
      Shell: 5.8.1 - /bin/zsh
    Binaries:
      Node: 14.19.2 - /usr/local/opt/node@14/bin/node
      Yarn: 3.2.0 - /usr/local/bin/yarn
      npm: 6.14.17 - /usr/local/opt/node@14/bin/npm
      Watchman: 2022.03.21.00 - /usr/local/bin/watchman
    Managers:
      CocoaPods: 1.11.2 - /usr/local/bin/pod
    SDKs:
      iOS SDK:
        Platforms: DriverKit 21.4, iOS 15.5, macOS 12.3, tvOS 15.4, watchOS 8.5
    IDEs:
      Android Studio: 2021.2 AI-212.5712.43.2112.8512546
      Xcode: 13.4.1/13F100 - /usr/bin/xcodebuild
    npmGlobalPackages:
      eas-cli: 0.54.1
      expo-cli: 6.0.1
    Expo Workflow: bare

Reproducible demo

There is none

@hirbod hirbod added CLI Versioned Expo CLI -- `npx expo start` needs validation Issue needs to be validated labels Jul 27, 2022
@raajnadar
Copy link
Contributor

I guess the same thing should happen for eject as well, last time I used the eject cmd it did not check the value in the json for platform

@brentvatne
Copy link
Member

@raajnadar - eject does not exist anymore, it was renamed to prebuild. the word eject doesn't make sense here anymore because everything continues working as before, you've just generated native projects.

@raajnadar
Copy link
Contributor

@brentvatne not sure when were these changes made, But I still remember I used the expo eject cmd recently

Ok that is not a big deal, I thought both do different work

@brentvatne
Copy link
Member

@raajnadar - it's just an alias for prebuild in expo-cli, and the command itself is marked as superseded under --help:

eject [path]                      Superseded by expo prebuild

if you use the new local cli, we tell you to run prebuild instead

╰─$ npx expo eject

  $ expo eject is not supported in the local CLI, please use npx expo prebuild instead

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 60 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

@github-actions github-actions bot added the stale label Oct 31, 2022
@hirbod
Copy link
Contributor Author

hirbod commented Oct 31, 2022

Not stale

@github-actions github-actions bot removed the stale label Nov 1, 2022
@brentvatne brentvatne added Issue accepted and removed needs validation Issue needs to be validated labels Nov 26, 2022
@expo-bot
Copy link
Collaborator

Thank you for filing this issue!
This comment acknowledges we believe this may be a bug and there’s enough information to investigate it.
However, we can’t promise any sort of timeline for resolution. We prioritize issues based on severity, breadth of impact, and alignment with our roadmap. If you’d like to help move it more quickly, you can continue to investigate it more deeply and/or you can open a pull request that fixes the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Versioned Expo CLI -- `npx expo start` Issue accepted
Projects
None yet
Development

No branches or pull requests

5 participants