Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Navigation modal are glitchy inside Expo go client #15482

Open
lucasmotta opened this issue Dec 8, 2021 · 14 comments
Open

React Navigation modal are glitchy inside Expo go client #15482

lucasmotta opened this issue Dec 8, 2021 · 14 comments
Labels
bug Expo Go The client distributed on app stores iOS Issue accepted

Comments

@lucasmotta
Copy link
Contributor

lucasmotta commented Dec 8, 2021

Summary

React-Navigation modals are glitchy inside a managed Expo app. When the same example is ejected, the modals work as expected (using the same version for all packages).

More information was reported on software-mansion/react-native-screens#932 - but since this issue only occurs inside Expo Go app, I assume it must be something going on with Expo.

Managed or bare workflow? If you have ios/ or android/ directories in your project, the answer is bare!

managed

What platform(s) does this occur on?

iOS

SDK Version (managed workflow only)

43.0.2

Environment

Expo CLI 4.13.0 environment info:
System:
OS: macOS 12.0.1
Shell: 3.3.1 - /usr/local/bin/fish
Binaries:
Node: 16.10.0 - ~/.local/share/nvm/v16.10.0/bin/node
Yarn: 1.22.15 - ~/.local/share/nvm/v16.10.0/bin/yarn
npm: 7.24.0 - ~/.local/share/nvm/v16.10.0/bin/npm
Watchman: 2021.09.06.00 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.11.2 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 21.0.1, iOS 15.0, macOS 12.0, tvOS 15.0, watchOS 8.0
IDEs:
Android Studio: 2020.3 AI-203.7717.56.2031.7678000
Xcode: 13.1/13A1030d - /usr/bin/xcodebuild
npmPackages:
expo: ~43.0.2 => 43.0.4
react: 17.0.1 => 17.0.1
react-dom: 17.0.1 => 17.0.1
react-native: 0.64.3 => 0.64.3
react-native-web: 0.17.1 => 0.17.1
npmGlobalPackages:
expo-cli: 4.13.0
Expo Workflow: bare

Reproducible demo

The demo running as a managed app:
https://github.com/lucasmotta/expo-go-navigation-issue

The same demo, but ejected:
https://github.com/lucasmotta/expo-go-navigation-issue/tree/ejected

Modal Header issue

Expo go (bug)

Simulator.Screen.Recording.-.iPhone.12.-.2021-12-08.at.18.55.06.mp4

Ejected (works)

Simulator.Screen.Recording.-.iPhone.12.-.2021-12-08.at.19.01.47.mp4

Modal Stacking issue

Expo go (bug)

Simulator.Screen.Recording.-.iPhone.12.-.2021-12-08.at.18.54.16.mp4

Ejected (works)

Simulator.Screen.Recording.-.iPhone.12.-.2021-12-08.at.19.02.25.mp4
@lucasmotta lucasmotta added the needs validation Issue needs to be validated label Dec 8, 2021
@brentvatne
Copy link
Member

it's not clear to me what is happening in the third video, "Modal Stacking issue" in Expo Go - did you possibly upload the incorrect video there?

@brentvatne brentvatne added bug Expo Go The client distributed on app stores and removed needs validation Issue needs to be validated labels Dec 10, 2021
@lucasmotta
Copy link
Contributor Author

Sorry @brentvatne, indeed I uploaded the wrong video. It's fixed now with the correct video - let me know if you need any more info.

@brentvatne
Copy link
Member

@lucasmotta - we will look into it! as recommended in the other thread, you can use EAS Build to get around this for now.

@brentvatne
Copy link
Member

@lukmccall and @EvanBacon have investigated this and haven't been able to find the root cause yet.

@expo-bot
Copy link
Collaborator

Thank you for filing this issue!
This comment acknowledges we believe this may be a bug and there’s enough information to investigate it.
However, we can’t promise any sort of timeline for resolution. We prioritize issues based on severity, breadth of impact, and alignment with our roadmap. If you’d like to help move it more quickly, you can continue to investigate it more deeply and/or you can open a pull request that fixes the cause.

@niemax
Copy link

niemax commented Jan 22, 2022

Sorry @brentvatne, indeed I uploaded the wrong video. It's fixed now with the correct video - let me know if you need any more info.

Hey! Did you find an alternative way without ejecting? I would be interested if there is one.

@brentvatne
Copy link
Member

@niemax - this will only occur within Expo Go, we're still not sure why. when you run your build with eas build you will not have this problem. I believe it also works as expected if you use expo-dev-client instead of Expo Go.

@hirbod
Copy link
Contributor

hirbod commented Feb 7, 2022

@brentvatne it is working as expected with expo-dev-client. Just verified it. It is only Expo Go causing this issue.

@RWOverdijk
Copy link

I just found this issue after experiencing the same issue where scrolling makes the height jump. At first I thought the jumping was the bug, but I now see that the initial height is the problem.

Is there a fix planned for this? Is there any way we can help?

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 60 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

@github-actions github-actions bot added the stale label May 26, 2022
@hirbod
Copy link
Contributor

hirbod commented May 26, 2022

Not stale

@github-actions github-actions bot removed the stale label May 26, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 60 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

@github-actions github-actions bot added the stale label Aug 24, 2022
@RWOverdijk
Copy link

Good bot

@github-actions github-actions bot removed the stale label Aug 24, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 60 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

@github-actions github-actions bot added the stale label Nov 22, 2022
@lukmccall lukmccall removed the stale label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Expo Go The client distributed on app stores iOS Issue accepted
Projects
None yet
Development

No branches or pull requests

8 participants