fix: #1530 use discriminator with several mappings for one schema #1534
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've decided I'll give it a try but as long as fixing
ValueByDiscriminator
seems pretty straightforward, it requires some more changes to support proper generation ofFromX
andMergeX
methods.Let's assume our
Dog
has breeds[ beagle, poodle ]
. It will produce a code:which seems fair if you're not planning to use it, but it compiles only if we specify our
breed
asrequired
.I am not fully aware of the intentions behind setting the mapping field in these methods, so I'm not sure if resigning from setting the field is the solution here.
Another pair of 👀 would be much appreciated. Cheers!