have you any suggested workarounds?

+1

I believe the issue am facing while terminating the task has to do with this feature request

Am using the celery [ v4.1.0 ] with Flask as : celery -A run.celery worker -P eventlet -c 50 --loglevel=info

[2018-05-11 17:16:28,137: ERROR/MainProcess] pidbox command error: NotImplementedError("<class 'celery.concurrency.eventlet.TaskPool'> does not implement kill_job",)
Traceback (most recent call last):
  File "/home/sreenadh/Projects/test_project/.tp/lib/python3.5/site-packages/kombu/pidbox.py", line 101, in dispatch
    reply = handle(method, arguments)
  File "/home/sreenadh/Projects/test_project/.tp/lib/python3.5/site-packages/kombu/pidbox.py", line 122, in handle_cast
    return self.handle(method, arguments)
  File "/home/sreenadh/Projects/test_project/.tp/lib/python3.5/site-packages/kombu/pidbox.py", line 116, in handle
    return self.handlers[method](self.state, **arguments)
  File "/home/sreenadh/Projects/test_project/.tp/lib/python3.5/site-packages/celery/worker/control.py", line 164, in revoke
    request.terminate(state.consumer.pool, signal=signum)
  File "/home/sreenadh/Projects/test_project/.tp/lib/python3.5/site-packages/celery/worker/request.py", line 248, in terminate
    pool.terminate_job(self.worker_pid, signal)
  File "/home/sreenadh/Projects/test_project/.tp/lib/python3.5/site-packages/celery/concurrency/base.py", line 115, in terminate_job
    '{0} does not implement kill_job'.format(type(self)))
NotImplementedError: <class 'celery.concurrency.eventlet.TaskPool'> does not implement kill_job

I believe the killing would be possible using Eventlet API corresponding to the greenthread.kill() ?

+1

+1

+1

+1

send PR, +1 will be blocked

+1

+1

+1

Well, this https://celery.readthedocs.io/en/latest/reference/celery.contrib.abortable.html can be useful. You can try to abort your task from outside (set state to ABORTED) and check this state in task with some period, if state is ABORTED you can raise some Exception. What do you think about this?

+1

@AlphaCaprice I tried this approach. I was not able to stop the process from outside. Everything is related to gevent third party app.

considering that we are going to move to python3.6+ asyncio/trio can we close this issue as won't fix??

I found a workaround. Might not work for everyone though.

I had a loop that had to run a heavy process. Couldn't revoke the task so the entire loop ran. So before starting the task, I made a file(let's say task_id.txt) and put a logic to check if the file existed on every iteration. I could delete the testfile if I wanted to revoke and the logic would raise an exception.

This is similar to AbortableTask as in the current iteration will still run, but was a work around as I couldn't use AbortableTask in my case.

considering that we are going to move to python3.6+ asyncio/trio can we close this issue as won't fix??

Sadly, yes. No one has fixed this so far so it probably won't get fixed.
If you feel differently, please come up with a PR and we will revisit that decision.

+100

+1