Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade dependencies #238

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

upgrade dependencies #238

wants to merge 5 commits into from

Conversation

njugray
Copy link
Contributor

@njugray njugray commented Aug 24, 2020

Checklist

  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines

Affected plugin(s)

  • beidou-webpack

Description of change

key dependencies upgrade:

  • css-loader: 0.28.7 -> 4.0.0
  • file-loader: 1.1.11 -> 6.0.0
  • less: 2.7.3 -> 3.12.2
  • less-loader: 4.0.6 -> 6.2.0
  • mini-css-extract-plugin: 0.7.0 -> 0.9.0
  • postcss-loader: 2.0.10 -> 3.0.0

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2020 •
edited

Codecov Report

Merging #238 into master will decrease coverage by 0.70%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   92.80%   92.10%   -0.71%     
==========================================
  Files          87       87              
  Lines        1627     1633       +6     
==========================================
- Hits         1510     1504       -6     
- Misses        117      129      +12
Impacted Files Coverage Δ
packages/beidou-webpack/lib/plugin/isomorphic.js 97.29% <ø> (ø)
packages/beidou-webpack/config/webpack/utils.js 93.75% <100.00%> (+0.41%) ⬆️
...s/beidou-webpack/config/webpack/webpack.browser.js 100.00% <100.00%> (ø)
...beidou-view-rax/app/view-middlewares/rax-render.js 42.85% <0.00%> (-57.15%) ⬇️
packages/beidou-view-rax/app/extend/helper.js 66.66% <0.00%> (-33.34%) ⬇️
packages/beidou-view-rax/lib/rax-view.js 76.92% <0.00%> (-23.08%) ⬇️
packages/beidou-webpack/app/middleware/webpack.js 84.37% <0.00%> (-12.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dce108...e17b918. Read the comment docs.

@codecov-io
Copy link

Codecov Report

Merging #238 (5b0011a) into master (6dce108) will decrease coverage by 1.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
- Coverage   92.80%   90.96%   -1.85%     
==========================================
  Files          87       56      -31     
  Lines        1627      819     -808     
==========================================
- Hits         1510      745     -765     
+ Misses        117       74      -43
Impacted Files Coverage Δ
packages/beidou-view-rax/lib/rax-view.js 20.00% <0.00%> (-80.00%) ⬇️
packages/beidou-view-rax/app/extend/helper.js 66.66% <0.00%> (-33.34%) ⬇️
packages/beidou-view-react/app/extend/helper.js
packages/beidou-webpack/config/config.default.js
...s/beidou-view-react/app/view-middlewares/render.js
...beidou-view-rax/app/view-middlewares/rax-render.js
...es/beidou-webpack/config/webpack/webpack.common.js
...ackages/beidou-view-react/config/config.default.js
packages/beidou-view-react/app.js
packages/beidou-view-react/config/config.local.js
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dce108...2109288. Read the comment docs.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@njugray @codecov-commenter @codecov-io @CLAassistant