Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add type hinting to codebase #252

Open
raybellwaves opened this issue Nov 2, 2022 · 2 comments
Open

add type hinting to codebase #252

raybellwaves opened this issue Nov 2, 2022 · 2 comments
Labels
idea
Milestone
1.0

Comments

@raybellwaves
Copy link
Collaborator

No description provided.

@raybellwaves raybellwaves added the enhancement New feature or request label Nov 2, 2022
@anitagraser anitagraser added this to the 1.0 milestone Nov 20, 2022
@Geometrein
Copy link

Hey, I believe this would be a very nice addition for lowering the learning curve.
What are your thoughts on the level of detail in the type annotations?

def _get_segments_for_ranges(traj: Trajectory, ranges: list) -> list:

or

def _get_segments_for_ranges(traj: Trajectory, ranges: List[SpatioTemporalRange]) -> List[Trajectory]:

@anitagraser
Copy link
Collaborator

Hi @Geometrein
In the example you provide, I prefer the second since the first is imho insufficient to be useful.

@anitagraser anitagraser added idea and removed enhancement New feature or request labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
idea
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@anitagraser @raybellwaves @Geometrein