Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predictions for ranges/sets of values #4260

Open
1 task done
rbkrejci opened this issue Jan 2, 2023 · 5 comments
Open
1 task done

Predictions for ranges/sets of values #4260

rbkrejci opened this issue Jan 2, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request Team: SQL & Text2SQL Anything related to the text-to-SQL project

Comments

@rbkrejci
Copy link

rbkrejci commented Jan 2, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

I'd like to retrieve a prediction filtering over a range of values rather than only individual exact values. Example:
select rental_price, rental_price_explain
from mindsdb.home_rentals_model
where sqft between 1000 and 1200 and neighborhood in ('berkeley_hills', 'westbrae', 'downtown');

This currently generates an error:
Only 'and' and '=' operations allowed in WHERE clause, found: BetweenOperation(op='between', args=( Identifier(parts=['sqft']), Constant(value=1000), Constant(value=1200) )

Describe the solution you'd like.

I'd like to have the ability to use filter criteria such as "in", "between", or "or" logic to retrieve a single prediction.

Describe an alternate solution.

No response

Anything else? (Additional Context)

https://mindsdbcommunity.slack.com/archives/C01S2T35H18/p1672320517307839

@tomhuds tomhuds added the enhancement New feature or request label Jan 4, 2023
@tomhuds tomhuds assigned tomhuds and unassigned paxcema Jan 4, 2023
@chandrevdw31
Copy link
Contributor

Hey @paxcema I just want to follow up on the above

@paxcema
Copy link
Member

paxcema commented Mar 3, 2023

From an ML point of view it's not immediately clear how to tackle this, but I suspect defining a distribution over values instead of a point sample may be the way to go. This is a major undertaking. Options seem to be:

  1. find a framework that specializes on this and write an integration for it.
  2. add support for this in Lightwood

@torrmal torrmal assigned martyna-mindsdb and unassigned tomhuds Jan 17, 2024
@torrmal
Copy link
Contributor

torrmal commented Jan 17, 2024

@martyna-mindsdb see if this is something we add to the list of things we want to do

@martyna-mindsdb
Copy link
Contributor

@torrmal
It has already been added to the list. We should support all basic WHERE conditions.

@ea-rus ea-rus added the Team: SQL & Text2SQL Anything related to the text-to-SQL project label Feb 6, 2024
@ea-rus
Copy link
Contributor

ea-rus commented Mar 21, 2024

related to
mindsdb/mindsdb_sql#279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team: SQL & Text2SQL Anything related to the text-to-SQL project
Projects
None yet
Development

No branches or pull requests

7 participants