Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment: Comment.Group should support a shorthand #2516

Open
hubertguillemain opened this issue Feb 11, 2018 · 6 comments
Open

Comment: Comment.Group should support a shorthand #2516

hubertguillemain opened this issue Feb 11, 2018 · 6 comments

Comments

@hubertguillemain
Copy link

I think it would make sense to keep the philosophy aligned with the rest of the library (use json arrays as props whenever possible)

@hubertguillemain
Copy link
Author

something like:
[
{
avatar: "/assets/images/avatar/small/matt.jpg",
author: "Matt",
metadata:"Today at 5:52 PM",
text:"How artistic",
},
{
avatar: "/assets/images/avatar/small/matt.jpg",
author: "Matt",
metadata: "Today at 5:52 PM",
text: "How artistic",
}
]

@brianespinosa
Copy link
Member

brianespinosa commented Feb 12, 2018

Thanks for opening this @hubertguillemain. There are a few *.Group type components that do not yet have shorthand API support. I think we just added this support to Button.Group for instance. It would be good if all of our *.Group components supported our shorthand API the same way.

PRs are welcome.

@layershifter layershifter changed the title (feat) Comment.Group should support a shorthand "comments" prop Comment: Comment.Group should support a shorthand "comments" prop Feb 12, 2018
@layershifter layershifter changed the title Comment: Comment.Group should support a shorthand "comments" prop Comment: Comment.Group should support a shorthand Feb 12, 2018
@stale
Copy link

stale bot commented May 13, 2018

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label May 13, 2018
@stale
Copy link

stale bot commented Aug 11, 2018

This issue will be closed due to lack of activity for 6 months. If you’d like this to be reopened, just leave a comment; we do monitor them!

@stale stale bot closed this as completed Aug 11, 2018
@layershifter layershifter reopened this Aug 12, 2018
@stale stale bot removed the stale label Aug 12, 2018
@stale
Copy link

stale bot commented Feb 8, 2019

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Feb 8, 2019
@layershifter layershifter removed the stale label Feb 8, 2019
@stale
Copy link

stale bot commented Aug 7, 2019

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants