Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime] Use c++17 for tests and tools #13035

Merged
merged 1 commit into from
May 29, 2024
Merged

[runtime] Use c++17 for tests and tools #13035

merged 1 commit into from
May 29, 2024

Conversation

hseok-oh
Copy link
Contributor

This commit updates cmake script to use c++17 for all tests and tools.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh hseok82.oh@samsung.com

@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label May 22, 2024
@hseok-oh hseok-oh requested a review from a team May 22, 2024 02:36
@hseok-oh
Copy link
Contributor Author

hseok-oh commented May 22, 2024 •
edited

Build fail on android: absl build fail. we need to bump up absl version and dependent packages.

SlavikMIPT
SlavikMIPT approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@SlavikMIPT SlavikMIPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh added PR/NO MERGE Please don't merge. I'm still working on this :) and removed PR/ready for review It is ready to review. Please review it. labels May 27, 2024
@hseok-oh hseok-oh marked this pull request as draft May 27, 2024 00:51
@hseok-oh
[runtime] Use c++17 for tests and tools
78a7f44 
This commit updates cmake script to use c++17 for all tests and tools.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
@hseok-oh hseok-oh marked this pull request as ready for review May 29, 2024 05:59
@hseok-oh hseok-oh added PR/ready for review It is ready to review. Please review it. and removed PR/NO MERGE Please don't merge. I'm still working on this :) labels May 29, 2024
@glistening glistening merged commit 6d9aec5 into Samsung:master May 29, 2024
10 checks passed
@hseok-oh hseok-oh deleted the c17_test_tool branch May 29, 2024 07:22
Torrero pushed a commit to Torrero/ONE_PUBLIC that referenced this pull request May 29, 2024
@hseok-oh @Torrero
[runtime] Use c++17 for tests and tools (Samsung#13035)
1930f8f 
This commit updates cmake script to use c++17 for all tests and tools.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunseoklee chunseoklee chunseoklee approved these changes

@SlavikMIPT SlavikMIPT SlavikMIPT approved these changes

@zetwhite zetwhite zetwhite approved these changes

Assignees
No one assigned
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hseok-oh @chunseoklee @SlavikMIPT @zetwhite @glistening