Draft: Enable observers on execution #13013
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
hseok-oh
commented
May 23, 2024
Comment on lines
583
to
584
| new exec::DataflowExecutor{std::move(lowered_graph), std::move(backend_contexts), tensor_regs, | ||
| std::move(code_map), tracing_ctx}; | ||
| if (options->he_profiling_mode) | ||
| { | ||
| std::vector<const backend::Backend *> backends; | ||
| for (const auto &pair : backend_contexts) |
There was a problem hiding this comment.
It was bug: use backend_contexts after std::move(backend_contexts)
c4437ba
to
f1a3b22
Compare
|
Update: create all observers on compile, check option on execution |
3286095
to
f99acec
Compare
|
34453df
to
3087850
Compare
This was referenced Jun 11, 2024
7c464ae
to
aa882d5
Compare
Create and register observers on execution, not compilation. It is more flexible and allows for more dynamic observation (ex. profile, dump on demand) ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com> Remove compile option: minmax_filepath, trace_filepath create on compile, check usage on execution move file creation introduce execution config and context Use workspace in compiler option
aa882d5
to
f7a2510
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create all observers on compile, and register enabled observers on execution, not compilation.
It is more flexible and allows for more dynamic observation (ex. profile, dump on demand)
ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh hseok82.oh@samsung.com