Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add partial import support & Stabilizing generic_full_path feature #20

Open
DenuxPlays opened this issue Mar 25, 2024 · 2 comments
Open

Add partial import support & Stabilizing generic_full_path feature #20

DenuxPlays opened this issue Mar 25, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@DenuxPlays
Copy link
Collaborator

DenuxPlays commented Mar 25, 2024 •
edited

Adding last missing feature

Add support for partial imports.
This is the last feature that we are missing and when this is implemented I think we can mark generic_full_path as stable.

Stabilizing the feature

I've now used the feature since I developed it and I have to say there isn't a case where it fails.
I do not know if someothers haved used so it would be great if someone could share their experience with it.

But I was sadly right about longer compile times and higher RAM usage.
The higher RAM usage can cause problems especially on PCs with a low amount of RAM. (8GB or less).

We cannot get rid of the higher RAM usage as we simply need to store more infromation.
Same with the disk usage we need to parse more to get the extra information needed.

I think we can say that this feature is stable.
But maybe you/others disagree or you miss some features.

Or maybe we should wait until the rust released they parallel front-end (see here) because this could potentially increase our RAM usage even more.
We have to test that though.
@ProbablyClem
Copy link
Owner

I haven't used it, but good to hear that it works 👍
I think we could mark it as stable, since it's not less tested than the rest of the crate...

It's behind a feature flag anyway so ne big deal.
You can submit a PR to update a readme since that's the only change 😄

@DenuxPlays
Copy link
Collaborator Author

I haven't used it, but good to hear that it works 👍 I think we could mark it as stable, since it's not less tested than the rest of the crate...

It's behind a feature flag anyway so ne big deal. You can submit a PR to update a readme since that's the only change 😄

Okay
I'll planed to add support for partial imports since that is the only thing that we currently not support.
I think I submit a pr (when I find time for it) and then mark it at stable.
I'll update this issue accordingly

@DenuxPlays DenuxPlays changed the title Stabilizing generic_full_path feature Add partial import support & Stabilizing generic_full_path feature Apr 8, 2024
@ProbablyClem ProbablyClem added documentation Improvements or additions to documentation enhancement New feature or request labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ProbablyClem @DenuxPlays