Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Bug Report ] Notification doesn't work without custom component #290

Closed
odolha opened this issue Feb 11, 2023 · 3 comments
Closed

[ Bug Report ] Notification doesn't work without custom component #290

odolha opened this issue Feb 11, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@odolha
Copy link

odolha commented Feb 11, 2023

Environment

* "vue": "^3.2.45",
* "tailwindcss": "^3.2.6",

Current Behavior

I'm trying to use the latest version, but the notifications/toasters don't seem to work as they used to.
Specifically, they show nothing if I use text or title and variant has no effect.

this.$Notification({ variant: 'success', text: 'this is great!', title: 'horray' });

It always just shows an empty container. The docs also don't mention how we should use the text/title/variant. It only shows a custom component usage.

The only thing that works indeed is if I give it a custom component to use (as per the example mentioned here https://equal-ui.github.io/Equal/components/notification).

Expected Behavior

It would be much better if it would support a simple title, text and variant. It should be rare to actually need something custom inside a notification.

Steps To Reproduce

  1. this.$Notification({ variant: 'success', text: 'this is great!', title: 'horray' });
  2. an empty notification box is shown

Anything else?

No response

@odolha odolha added the bug Something isn't working label Feb 11, 2023
@quatrochan
Copy link
Collaborator

Notifications page will be updated soon

@quatrochan
Copy link
Collaborator

Notifications page updated. Some breaking api changes, but now we have full useNotification hook.

@odolha
Copy link
Author

odolha commented Mar 6, 2023

works like a charm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants