Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Feature Request ] Test components #252

Closed
AbrahemAlhofe opened this issue Jul 5, 2021 · 6 comments
Closed

[ Feature Request ] Test components #252

AbrahemAlhofe opened this issue Jul 5, 2021 · 6 comments

Comments

@AbrahemAlhofe
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When I was working on implementing `scrollToSelectedOption`, I was confused on what are the requirements,  in another meaning what this method should do, and how I can be sure that I hadn't broken anything else

Describe the solution you'd like

We should test our components

Describe alternatives you've considered

There are two approaches to test components

1. Using `cypress`
   We are here will use development page ( `localhost:3000` )
2. Using `jest`
   We are here will mount components headless to test it, nevertheless I don't prefer that approach

Additional context

I will work on test the components after the convention about the possible approaches and details, and how to migrate from non-tested components to test-based components
@quatrochan
Copy link
Collaborator

I prefer cypress too. Testing is an important thing for v1.0 to be stable and production-ready

@AbrahemAlhofe
Copy link
Contributor Author

I will work on it if you will do it too, how we can organize that

@quatrochan
Copy link
Collaborator

You can suggest cypress setup in the project with a basic test example for any component (it-button would be a good fit). After cypress setup is done we can proceed with tests. Also you can write you telegram or discord for direct communication

@AbrahemAlhofe
Copy link
Contributor Author

I have made my email visible you can send me an email to communicate

@AbrahemAlhofe
Copy link
Contributor Author

AbrahemAlhofe commented Jun 12, 2022 •
edited

Cypress was announced with a new version (Cypress 10), it is in beta but I tried it, it's great, we can use it to test components but when I started testing components (specifically it-button) I had no idea what the main things should we test it.

image
image

@quatrochan
Copy link
Collaborator

Cypress was announced with a new version (Cypress 10), it is in beta but I tried it, it's great, we can use it to test components but when I started testing components (specifically it-button) I had no idea what the main things should we test it.

image image

I hope one day we will setup tests for the component. It'll probably be Vitest and Cyrpess. I'll move this into discussion

@Equal-UI Equal-UI locked and limited conversation to collaborators Jan 16, 2023
@quatrochan quatrochan converted this issue into discussion #281 Jan 16, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quatrochan @AbrahemAlhofe