Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat( components ): implement scrollToSelectedOption method #251

Merged

Conversation

AbrahemAlhofe
Copy link
Contributor

- bump package version to 0.78.0
- cash `ul.it-select-list` element in `dropdownRef`
    | to use it in `scrollToSelectedOption`
- make `selectOption` use option's index instead of `option: TOption`
    | to set `selectedOptionIndex` to get with it
    | the current selected option's reference
- make `scrollToSelectedOption` set `scrollTop` of `scrollerRef`
  with `offsetTop` of `selectedOption`

close #250

    - bump package version to 0.78.0
    - cash `ul.it-select-list` element in `dropdownRef`
        | to use it in `scrollToSelectedOption`
    - make `selectOption` use option's index instead of `option: TOption`
        | to set `selectedOptionIndex` to get with it
        | the current selected option's reference
    - make `scrollToSelectedOption` set `scrollTop` of `scrollerRef`
      with `offsetTop` of `selectedOption`

close Equal-UI#250
@quatrochan
Copy link
Collaborator

Great work!

@quatrochan quatrochan merged commit f527031 into Equal-UI:master Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Feature Request ] Impalement scrollToSelectedOption in select hooks
2 participants