-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Feature Request): Badge if a content creator gave access to their private dislikes #130
Comments
I really love this idea. I have made some badge designs in SVG for both dark and light theme. Feel free to redesign, or do anything since it's just based on my preferences. These images below are just preview using DevTools. You can download the SVG Files: Or visit the Figma project: https://www.figma.com/file/2f0kBjLlt0V5E9NfxGWSk9/Dislike-Badge?node-id=0%3A1 |
@hisamafahri |
@mattphelps-8451 That's a good idea |
the hexagon looks nice, and contrasts with the circle check mark if they're verified by youtube |
This is similar to #108 |
My thoughts
|
I'd say just use the icon of this extension, to show they contribute data to this extension |
May I suggest something like that? It is more neutral/positive than the original Design. (Inspired/Copied from @hisamafahri idea) |
I mentioned this on the Discord yesterday. Thanks for getting an issue created for this. Some feedback the badge is a bit small, and this might be an accessibility issue for visually impaired users. Also do we have a pull request to look at yet, would be interested in taking on making sure the aria-tags are setup correctly. |
I prefer option 2. Option 1 is a little off putting in terms of placement.
Green is easier to see than gray, could you look at making it red like the subscribe option? I’m curious what it’d look like.
…Sent from my iPhone
On Dec 1, 2021, at 1:24 PM, Max ***@***.***> wrote:
Thoughts?
Adding a badge to the dislike button itself and using Youtube's tooltip style feels the most organic
Making it green gets attention and lets people know immediately that dislike data is legit and creator chose to share it
Option 1
Option 2
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Could you change the checkmark from black to light gray or white?
…Sent from my iPhone
On Dec 1, 2021, at 1:29 PM, Max ***@***.***> wrote:
Feels a bit like too much IMO
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
I like the inline view, maybe we make this an option in the add-on to pick the image you want. I would personally like to see a white outline-style one that matches the other icons in the bar, but the green+white is also very nice. |
@bonn2 I like the outline idea |
I personally prefer Red+White. It looks better to me and fits in with the YouTube Red color. Green seems a bit out of place personally.
…Sent from my iPhone
On Dec 1, 2021, at 1:48 PM, Max ***@***.***> wrote:
@bonn2 I like the outline idea
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
@irlcatgirl I agree with @sy-b's point that it should have a positive reinforcement effect. Youtube red color doesn't have that effect while green does 🤔 |
How would a normal user get to know its meaning. Suggestion: use words also |
Maybe instead of a checkmark it could be a little dislike icon in the symbol |
I like the idea of adding a settings page to pick the icon. Perhaps include an option for custom CSS/SVG for the icon.
…Sent from my iPhone
On Dec 1, 2021, at 1:45 PM, Brett Bonifas ***@***.***> wrote:
I like the inline view, maybe we make this an option in the add-on to pick the image you want. I would personally like to see a white outline-style one that matches the other icons in the bar, but the green+white is also very nice.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Green + white looks best to me. Red + white is good as well, but green is better to convey "positive" message. |
We should have a ? Icon perhaps colored yellow or orange to show we are estimating it vs know for a fact. I agree a tool tip would help here as well.
…Sent from my iPhone
On Dec 1, 2021, at 2:48 PM, sy-b ***@***.***> wrote:
& what if the data is gathered by other sources?
#108 takes this into account.
If the aim of this discussion is expanded to include other sources, then I'll close #108
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Should that badge be adaptable to theme? |
I think that would be a good idea
…Sent from my iPhone
On Dec 2, 2021, at 12:46 AM, sy-b ***@***.***> wrote:
Should that badge be adaptable to theme?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Personally, I'd like to have some indicator that does not future distract from the actual content by being bright and flashy |
I'm indecisive here, I would say that the rest of the community should chime in for the default, I would only ask its left as a configurable flag. Perhaps use Green by default but allow people to swap to the YouTube Red one. I think user choice is important here but am far from a UX expert, my idea may be bad, so I'll ask the rest of the community to vote / discuss about this. |
Looks great |
This is so great, it would integrate with my project as well. OpenDislikeAPI |
Extension or Userscript?
Both
Request or suggest a new feature!
A badge to the right of the verified checkmark if that specific content creator has allowed the API to scrape their dislike information, so you can be certain that their dislikes are "verified"
Ways to implement this!
I was hoping for maybe a little badge next to their name, I made a small mock up:
for the "can you work on this" i could make a better dislike design, but other than that, I have 0 coding experience
Can you work on this?
The text was updated successfully, but these errors were encountered: