Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana Dashboard Angular deprecated #947

Open
hawbirr opened this issue Mar 26, 2024 · 12 comments
Open

Grafana Dashboard Angular deprecated #947

hawbirr opened this issue Mar 26, 2024 · 12 comments

Comments

@hawbirr
Copy link

hawbirr commented Mar 26, 2024

hi there,
I was wondaring if there is any chance to update the Grafana dashboard, as we get the following alering from grafana.
"""
Legacy alert rules are deprecated

You have legacy alert rules in this dashboard that were deprecated in Grafana 11 and are no longer supported.
"""
Angular plugin

This plugin uses a deprecated, legacy platform based on AngularJS and will stop working in future releases of Grafana.
"""

as it turns out grafana no longer support Angular any more and they have move to React.

we are wondering if there will be an update for the dashboard?

image image

Angular support deprecation

Thank you for your hard and amazing work.
Regards,
Hawbir

@AlexanderBand
Copy link
Member

Thanks for the report and the compliments.

What I did at the time is a JSON export of a Grafana layout I created and made it available as a dashboard on grafana.com. I wasn't aware it could contain a platform specific dependency, but now I see "Graph (old) 5.0.0" appears to cause this issue.

Let me try to upgrade to a new Grafana version and recreate the dashboard.

@hawbirr
Copy link
Author

hawbirr commented Apr 6, 2024

Great thank you for your time and your help, it’s really appreciated.

@M0NsTeRRR
Copy link

Hello,

Have you started working on it? I would be happy to contribute and migrate the existing dashboard if you haven't started yet.
Let me know :)

@AlexanderBand
Copy link
Member

Have you started working on it? I would be happy to contribute and migrate the existing dashboard if you haven't started yet. Let me know :)

Hi @M0NsTeRRR! It's been quite the hectic couple of weeks so I haven't been able to work on it. If you could migrate the dashboard, that would be awesome. Happy to send you some Routinator stickers for the trouble. 😊🚀

@M0NsTeRRR
Copy link

Hello,

No worries :)

I've migrated the dashboard (without adding new metrics) but it's a good starting point for another iteration if someone wants to delve into it.

A few points to note:

  • I've added an instance variable to handle multiple Routinator metrics from different RPKI instances.
  • I've removed the Rsync statistics in "Update Duration" and "Connection Status" as I can't correlate them to the repository variable.
  • I've removed the alert dashboard, as Routinator doesn't provide any Prometheus rules in its documentation. This could lead to confusion, as currently, it reports every alert from alertmanager without filtering.

Dashboard :
Routinator 0.9.0 and newer-1713777953543.json

I didn't create a PR because I only see the dashboard on the Grafana website, but I could do it if you tell me where.
I let you tell me if it's look good for you and if so, you can update the dashboard on grafana website :)

Regards,
PS : Thanks to NLnetLabs for the amazing open source work :)

Screenshots :
image
image

@AlexanderBand
Copy link
Member

AlexanderBand commented Apr 22, 2024

Hi @M0NsTeRRR! I just spun up a Grafana box point at a local Routinator and the one running at the RIPE NCC to test out your dashboard. It's great, thanks so much!

Screenshot 2024-04-22 at 15 56 48

You made excellent calls on the instance variable, rsync stats and alerts dashboard. It's much better this way. I'm happy to replace the Routinator dashoard on Grafana.com with your version and credit you. Please send me a message via alex@nlnetlabs.nl with your address details if you would like some awesome stickers.

All the best! 💚

@M0NsTeRRR
Copy link

Awesome, thank you! 🚀

@hawbirr
Copy link
Author

hawbirr commented Apr 23, 2024

Guys thank you for your hard work appreciate it.

I have a question which maybe not the place for it.
but since you guys working on this may know a way/
I was wondering, if there is a way to get (our's and our clients) AS-number rpki validation number and which prefixes is validated and which one is not validated and show them on grafan on the dashboard?

Again thank you for your support and amazing work.

@M0NsTeRRR
Copy link

Not with the metrics exposed by routinator. Check on /metrics you will see all routinator metrics.

To achieve that you could create an external exporter to retrieve this data based on routinator API

@AlexanderBand
Copy link
Member

To monitor specific ASNs and prefixes I recommend running BGPAlerter.

@hawbirr
Copy link
Author

hawbirr commented Apr 23, 2024

To achieve that you could create an external exporter to retrieve this data based on routinator API

can you please explain it more ? or if there is a guide or a link you can share that will be great

@hawbirr
Copy link
Author

hawbirr commented Apr 23, 2024

To monitor specific ASNs and prefixes I recommend running BGPAlerter.

Thank you for sharing it, will test it out and see. I want to get it and shown on Routinator's dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants